-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update keychain and namadillo names #391
Conversation
1. Clone the [namada-interface repository](https://github.com/anoma/namada-interface). | ||
2. Follow the installation instructions in `README.md`. | ||
3. `cd` into the `namada-interface/apps/extension` directory and run `yarn start:chrome`. This will build the extension and place it in the `namada-interface/apps/extension/build` directory. It also starts the dev server which will watch for changes. | ||
4. `cd` into the `namada-interface/apps/namada-interface` directory and run `yarn dev:local` in order to launch a local instance of the web wallet. | ||
3. `cd` into the `namada-interface/apps/extension` directory and run `yarn start:chrome`. This will build the Namada Keychain extension and place it in the `namada-interface/apps/extension/build` directory. It also starts the dev server which will watch for changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we should be more explicit on where the build goes here:
namada-interface/apps/extension/build/chrome
3. `cd` into the `namada-interface/apps/extension` directory and run `yarn start:chrome`. This will build the extension and place it in the `namada-interface/apps/extension/build` directory. It also starts the dev server which will watch for changes. | ||
4. `cd` into the `namada-interface/apps/namada-interface` directory and run `yarn dev:local` in order to launch a local instance of the web wallet. | ||
3. `cd` into the `namada-interface/apps/extension` directory and run `yarn start:chrome`. This will build the Namada Keychain extension and place it in the `namada-interface/apps/extension/build` directory. It also starts the dev server which will watch for changes. | ||
4. `cd` into the `namada-interface/apps/namadillo` directory and run `yarn dev:local` in order to launch a local instance of Namadillo. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can now just run yarn dev
instead of yarn dev:local
!
4. Add the extension to the browser. For example, in Chrome, you can go to `chrome://extensions/` and click `Load unpacked` and select the `namada-interface/apps/extension/build/chrome/` folder. | ||
|
||
## Receiving tokens | ||
You can show the address of any account by pressing the `Receive` button in the initial view under the "Total Balances" tab. You can copy the address by clicking the copy icon next to the address. | ||
You can show the address of any account by pressing the `Receive` button in the initial view under the `Total Balances` tab. You can copy the address by clicking the copy icon next to the address. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is no longer the case, there is no Total Balances
tab:
You can show the address of the current account by hovering over the account name in the top right corner. Clicking it will copy it to the clipboard.
This will also display a QR code that can be scanned by a mobile wallet. | ||
|
||
## Sending Transactions | ||
|
||
In order to send transactions, you can press the `Send` button in the initial view under the "Total Balances" tab. This will open a modal that will allow you to send tokens to any account, from any account in your wallet that has a positive balance. | ||
In order to send transactions, you can press the `Send` button in the initial view under the `Total Balances` tab. This will open a modal that will allow you to send tokens to any account, from any account in your wallet that has a positive balance. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would remove this for now - this is referring to the old Namada Interface. Transfers aren't enabled in this phrase
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove the whole section on Sending Transactions
for now?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If it is known right now how this will work even before transfers are enabled on mainnet, I think we should include the right info here. For example, we'd like people to be able to use this on a testnet where transfers are enabled. But if it is unknown right now, then it is ok to remove, as long as we make sure to come back here once known.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That makes sense! Maybe we (on the interface team) can open PRs to get the docs updated as soon as a feature is testable, at least on the testnet? I am fine with removing it for now, I feel like it will be confusing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, yeah that sounds good. Will remove for now, and would be good for the Interface team to keep in mind updating the docs as you update your code and features.
@@ -40,14 +40,17 @@ Scroll down until you find Namada in the list, and select the newest version fro | |||
|
|||
</Steps> | |||
|
|||
## Using the Ledger app with the browser extension | |||
## Using a Ledger with Namada Keychain (browser extension) | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we need a disclaimer here that this will only work on Chrome-enabled browsers. Firefox removed the USB transport. We only show Connect to Hardware Wallet
when it is available in the browser.
|
||
### Interact | ||
Once connected, you can use the Interface to make transfers or stake with a validator (Note: some functionality may be missing on testnet). | ||
Whenever you submit a transaction to the chain, you will be prompted to enter your password to allow the extension to sign using your private key. | ||
Once connected, you can use Namadillo to make transfers or stake with a validator (Note: some functionality may be missing on testnet). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is mostly correct, but transfers aren't enabled currently.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does the transfer functionality generally exist though?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't have the UI for this currently. Phase 3 will introduce the IBC & Shielded Transfer views, which are being developed right now!
6e4d1d1
to
19f369b
Compare
change 'Namada extension' to 'Namada Keychain' and 'Namada Interface' to 'Namadillo' to match the official names